-
Notifications
You must be signed in to change notification settings - Fork 528
Example vite web app #2967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Example vite web app #2967
Conversation
I have signed the CLA! |
@sdcooke my apologies for seeing this only now. This looks very interesting, let me have a look now. |
@wcandillon no worries - I'm now on the latest version of react-native-skia and everything (including animations) seems to be working so I don't think there's any investigation to be done. This example app could still potentially be useful for future testing though. |
I like the idea but I couldn't run the example unfortunately:
|
Ah yes this is the problem I've experienced in my app. Since 3.17.2 reanimated has included JSX in |
I've pushed a workaround for the JSX in .js files issue - it only works in dev, not build. Despite skia and the animations working well in my app, they don't seem to be working in this example. I'm going to have to come back to this another time, but if you're interested you should be able to run |
I got the build working with this
|
Example web app using vite/esbuild. Getting the configuration to work in this monorepo was a little awkward, so there might be some unnecessary code here but I've tried to keep it as minimal as possible.
Reverting 6443ac2 causes the error reported in #2960 to show when running
yarn dev
in this app's directory.The app itself has a simple page with 2 skia examples using reanimated shared values, neither of which works (possibly related to #2943).